fix: vendor older version of packaging for python 3.5 #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quite an enormous diff considering the very narrow use of the library in the upcoming pip decorator. Should we instead consider hoisting the implementation for the following, if these are all we need in the future? from metaflow._vendor.packaging.tags import (
_cpython_abis,
compatible_tags,
cpython_tags,
mac_platforms,
) |
savingoyal
approved these changes
Sep 12, 2023
|
unfortunately getting these methods and the transitive methods cleanly out of packaging is not a straightforward procedure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendored version of
packagingdoes not work for python 3.5 as it contains types. Vendored an older version for the python 3.5 use case